[4.0] com_menu - Change Featured Icon to Home Icon in by coolcat-creations · Pull Request #29016 · joomla/joomla-cms

coolcat-creations · 2020-05-09T22:21:09Z

Pull Request for Issue #28976

Summary of Changes

Changed the Default Icon in Menus to a home icon. If it has to be called home or default could be discussed in another issue. This PR makes a difference between the featured - action and the set menu item as default action. It also adds the possibility to pass the active and inactive iconclass suffix to the isDefault method.

Testing Instructions

apply patch
see if the home Icon on monolingual sites is now a home icon
the non-default items are for now a simple circle
on a multilingual website the home icon should be still a flag like before.

Expected result

Sidebar:

Actual result

infograf768 · 2020-05-10T05:57:30Z

Remark 1:

Size of icon is very different between sidemenu and Menu dasboard. Menu dashboard is better imho.

Remark 2:
Density of Yellow is very different between the featured star (for articles manager) and Home icon set to All languages in menu items manager. Articles manager star density is better imho.

The same colour is applied

color: var(--warning);
border-color: var(--warning);

The issue comes from

.disabled {
    opacity: .4;
}

These "issues" are unrelated to this patch but it would be good to solve them at the same time.

coolcat-creations · 2020-05-10T07:57:57Z

Yes, this PR is only about to change the type of the icon, not the color or size - for color we would need another class in the table header and for sizes it’s also not bound to only the home icon but the general interface. see later comment :-)

adj9 · 2020-05-10T09:54:47Z

I have tested this item ✅ successfully on 109a7b2

Apply the PR and I've change the icon for menu.
I've do an article in person lang and see the icon should

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.}

coolcat-creations · 2020-05-10T10:10:53Z

I have tested this item ✅ successfully on 109a7b2

Apply the PR and I've change the icon for menu.
I've do an article in person lang and see the icon should

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.

Thank you!

coolcat-creations · 2020-05-10T10:50:17Z

@adj9 @infograf768 I added the styling for the home item to not have the disabled class and added a "not-allowed" cursor. Can you retest?
For the icon sizes I think a separate PR would be better.

infograf768 · 2020-05-10T11:21:05Z

will do tomorrow.

infograf768 · 2020-05-10T16:10:49Z

I have tested this item ✅ successfully on 38bc020

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.}

administrator/components/com_menus/tmpl/items/default.php

infograf768 · 2020-05-11T05:43:23Z

@coolcat-creations

I suggest you also add a few lines above

  &.featured-disabled {
    opacity: 1;
  }

as this will now also solve density in Installed Languages and Template Styles for the default star colour.

N6REJ · 2020-05-11T08:05:29Z

@coolcat-creations

  &.disabled .icon-home {
    color: $state-warning-bg;
    border-color: $state-warning-bg;
  }

should be

&.disabled .fas.fa-home,
  &.disabled .icon-home {
    color: $state-warning-bg;
    border-color: $state-warning-bg;
  }

While below is preferred, I understand for b/c reasons that may not be possible at this time.

  &.disabled .fas.fa-home {
    color: $state-warning-bg;
    border-color: $state-warning-bg;
  }

Co-authored-by: Quy <quy@fluxbb.org>

coolcat-creations · 2020-05-12T12:22:24Z

@N6REJ - I can't add code that is not applying yet, you would need to add this into your PR after mine is merged or me after yours is merged, but not before both are merged.

coolcat-creations · 2020-05-12T12:23:36Z

&.featured-disabled {
opacity: 1;
}

@infograf768 - May I create a seperate PR for that? I prefer not to mix up too much in case something needs to be looked up later or reverted.

infograf768 · 2020-05-12T16:00:51Z

@infograf768 - May I create a seperate PR for that? I prefer not to mix up too much in case something needs to be looked up later or reverted.

Sure, but don’t forget! 😺

infograf768 · 2020-05-12T16:01:53Z

I have tested this item ✅ successfully on 0838c6d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.}

Quy · 2020-05-12T19:00:45Z

I have tested this item ✅ successfully on 0838c6d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.}

Quy · 2020-05-12T19:00:53Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29016.}

infograf768 · 2020-05-13T05:21:42Z

Tks

infograf768 · 2020-05-13T05:22:54Z

@coolcat-creations
Now you can make the PR for #29016 (comment) ;)

@Quy

* several single icons found * eye close * eye * admin page title * $iconimage * sub-menu * icon-delete * mapping non same named. * reformat * Update administrator/templates/atum/scss/pages/_com_privacy.scss ty brian Co-Authored-By: Brian Teeman <brian@teeman.net> * refresh * refresh * remove * featured * featured * column sort icon * square * $displaydata * [class^='icon-'] * make fa-check green * com_contacts featured * more featured * more publish/unpublish * com_categories * newsfeeds * associations * $iconStates * fixed broken _icons.scss * icon-ban-circle * revert to icon-home per jm * revert to icon-home per jm * revert to icon-home per jm * [4.0][RTL] CSS logical properties init * Update _modals.scss * use margin-inline * Update _modals.scss * Revert "Update _modals.scss" This reverts commit eb0d8bb. * Revert "use margin-inline" This reverts commit 6b264dd. * Use margin-inline-end in atum's _header.scss * Fix CS from last commit in atum's _header.scss * working on #28607 * working on #28607 ugh * working on toolbar cross-reference missing from part 1 * icon-loop fix. * finder fix * more loop->sync changes * more loop->sync changes * puzzle -> puzzle-piece * puzzle -> puzzle-piece * joomla brand * address->file-alt * stack->copy * added more to star, such as default * removed blank line * equalizer->sliders-h * lightning->bolt * checkin->check-square * comments-2->comments * power-cord->plug * info-2->info-circle * generic not fixed * generic not fixed * workaround for generic * drone fix? * puzzle->puzzle-piece * per luca * match button icon-class to toolbar * chevron & publish * publish/unpublish star. NEEDS REVIEW! * publish/unpublish star. NEEDS REVIEW! * few more icons * more folders * conflict fix. * com_template->modals * modifed jgrid to handle known active classes * arrow-down3 -> caret-down * icon-checkedout -> fa-lock * icon-puzzle -> puzzle-piece * trying to fix drone * trying to fix drone * trying to fix drone * else if fix per quy * Update layouts/joomla/button/iconclass.php ty quy Co-authored-by: Quy <quy@fluxbb.org> * Update layouts/joomla/button/iconclass.php ty quy Co-authored-by: Quy <quy@fluxbb.org> * code format fix per quy * code formatting changes per @Quy * code formatting changes * articles toolbar icon * remove space before 'fas' * featured * com_contact * featured * preview = icon-eye -> fas fa-eye * workflows featured * added mapping for $inactive class * missing closing ?> * Increase Opacity of disabled Featured Icons * Change Icon Classes Add Font Awesome Regular to Atum Fix broken Icons after change * Update build/media_source/com_categories/js/shared-categories-accordion.es6.js ty sharky Co-authored-by: SharkyKZ <sharkykz@gmail.com> * Update build/media_source/system/js/fields/passwordview.es6.js ty sharky.. I suck @ js. Co-authored-by: SharkyKZ <sharkykz@gmail.com> * Update build/media_source/system/js/fields/passwordview.es6.js Co-authored-by: SharkyKZ <sharkykz@gmail.com> * Update layouts/joomla/toolbar/title.php Co-authored-by: Quy <quy@fluxbb.org> * Update administrator/templates/atum/scss/template-rtl.scss Co-authored-by: Quy <quy@fluxbb.org> * pr #29016 compatibility fix. * pr #29016 compatibility fix. icon-default -> fa-home * Update FeaturedButton.php Add line break * Update FeaturedButton.php New line * Update FeaturedButton.php * Update FeaturedButton.php * removed stupid package-lock.json * b/c compatibility fix * b/c compatibility fix * Revert "b/c compatibility fix" This reverts commit 10c4611 * "b/c compatibility fix" * shelving * shelving * b/c compatability fix as found by jm. * phpcs fix * phpcs fix * phpcs fix * conflict fix. * conflict fix. * Revert "conflict fix." This reverts commit ef96c0f * Revert "conflict fix." This reverts commit 4aa7349 * removed improperly kept 133-147 Co-authored-by: Brian Teeman <brian@teeman.net> Co-authored-by: Richard Fath <richard67@users.noreply.github.com> Co-authored-by: ciar4n <ciaran@joomla51.com> Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: coolcat-creations <mail@coolcat-creations.com> Co-authored-by: SharkyKZ <sharkykz@gmail.com> Co-authored-by: infograf768 <infografjms@gmail.com>

* Change Featured Icon to Home Icon in com_menu * Change Icon class * Change Default icon in sidebar menu too * Different class for disabled Home item * Update administrator/components/com_menus/tmpl/items/default.php Co-authored-by: Quy <quy@fluxbb.org> Co-authored-by: Quy <quy@fluxbb.org>

icon-default -> fa-home

Change Featured Icon to Home Icon in com_menu

7c9c3bf

joomla-cms-bot added the PR-4.0-dev label May 9, 2020

coolcat-creations changed the title ~~Change Featured Icon to Home Icon in com_menu~~ [4.0] com_menu - Change Featured Icon to Home Icon in May 9, 2020

coolcat-creations added 2 commits May 10, 2020 00:33

Change Icon class

0b04774

Change Default icon in sidebar menu too

109a7b2

alikon mentioned this pull request May 10, 2020

[4.0] Template Atum Icon for Home Item in Menu #28976

Closed

Different class for disabled Home item

38bc020

Quy reviewed May 10, 2020

View reviewed changes

administrator/components/com_menus/tmpl/items/default.php Outdated Show resolved Hide resolved

Update administrator/components/com_menus/tmpl/items/default.php

0838c6d

Co-authored-by: Quy <quy@fluxbb.org>

Quy changed the title ~~[4.0] com_menu - Change Featured Icon to Home Icon in~~ [4.0] com_menu - Change Featured Icon to Home Icon in May 12, 2020

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 12, 2020

infograf768 merged commit 8cec1f3 into joomla:4.0-dev May 13, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 13, 2020

infograf768 added this to the Joomla 4.0 milestone May 13, 2020

coolcat-creations mentioned this pull request May 13, 2020

[4.0] Template Atum - Improve appereance of backend icons #29050

Merged

Quy mentioned this pull request May 14, 2020

[4.0] Icon- TO fa ( part 3 ) #28075

Merged

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020

pr joomla#29016 compatibility fix.

5fbf9ea

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020

pr joomla#29016 compatibility fix.

734ae10

icon-default -> fa-home

Uh oh!

Comments

Conversation

coolcat-creations commented May 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Expected result

Actual result

Uh oh!

infograf768 commented May 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coolcat-creations commented May 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adj9 commented May 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coolcat-creations commented May 10, 2020

Uh oh!

coolcat-creations commented May 10, 2020

Uh oh!

infograf768 commented May 10, 2020

Uh oh!

infograf768 commented May 10, 2020

Uh oh!

Uh oh!

infograf768 commented May 11, 2020

Uh oh!

N6REJ commented May 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coolcat-creations commented May 12, 2020

Uh oh!

coolcat-creations commented May 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

infograf768 commented May 12, 2020

Uh oh!

infograf768 commented May 12, 2020

Uh oh!

Quy commented May 12, 2020

Uh oh!

Quy commented May 12, 2020

Uh oh!

infograf768 commented May 13, 2020

Uh oh!

infograf768 commented May 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coolcat-creations commented May 9, 2020 •

edited

Loading

infograf768 commented May 10, 2020 •

edited

Loading

coolcat-creations commented May 10, 2020 •

edited

Loading

adj9 commented May 10, 2020 •

edited

Loading

N6REJ commented May 11, 2020 •

edited

Loading

coolcat-creations commented May 12, 2020 •

edited

Loading